SRE here, Strong disagree with do not fail readiness and liveness checks on upstream dependencies failing. There are several reason to do so and unless you have extreme start up time, what's the problem with restarting?<p>Maybe DNS has changed on you but you are stuck with bad local cache because you poorly respect TTLs (Looking at you Java), reseting the process will clear that cache away.<p>Maybe TCP connections are in stuck weird state, resetting the process generally helps with that.<p>Maybe someone gave you bad ENV VARs and you cannot connect to database, by refusing to progress the rollout, no outage generated.<p>So yea, if you are not ready to do work including critical upstream dependencies, don't lie to system and say you are.
1. was already mentioned in sibling - cascade failures<p>2. you'll have massive number of restarts for various flake reasons and missing things that got papered over with restarts until you hit 1 and everything is broken. another popular version of this is "just restart when memory leaks too much"
Thundering herd / cascading outages. You take out a large enough portion of your fleet, and the remaining load overloads your remaining nodes one by one as they restart, so you can never have enough healthy nodes.
<i>SRE team debates correctness versus availability for the 540th time this year</i><p>You're both correct, of course!
You'd be surprised how many engineering leaders don't understand the CAP theorem and will fail engineers on interviews for picking the one they don't agree with instead of communicating their expectations clearly (dodged a bullet on that one ...)
What this guy said :point_up:<p>My personal take-away is this: whatever you choose, make sure it's consistent across services (not serviceA behaves like X and serviceB like Y) and make sure eng teams know _how_ these are configured and what can go wrong. They'll figure out the rest.
That's a problem for circuitbreakers on these kinds of actions, not lying on health checks.<p>Something like healthcheck fails -> restart -> healthcheck fails -> restart -> healthcheck fails -> circuit breaker trip, alarm raised, give up until manual intervention or X minutes have passed
That circuitbreaker exists, by default. It is "CrashloopBackoff", here, and TFA covers it. (& it's an "until X minutes have passed" kind, by default.)
My favourite: misconfigured Linkerd setup that causes CA certs to rotate every month :) Definitely worth restarting on that
What are your feelings about using initContainers and wait-for-it to skirt the thundering-herd problem?
The better solution is to not have too many critical upstream services :)
> what's the problem with restarting?<p>Exponential backoff can delay recovery up to kubelet’s maxContainerRestartPeriod (default 5m).
cascading failures on upstream services. then you get 20 different services failing instead of the single one.