17 comments

  • traceroute662 hours ago
    At $work we use Tailscale mostly because we were running into too many random issues with NAT with our standard DIY Wireguard setup, especially when people were working from hotels and other places with half-ass network setups.<p>But we don&#x27;t trust Tailscale. Just look at the thousands of unresolved Github issues, many of which are actually quite important&#x2F;useful but have been ignored for months and years.<p>We very much fear at $work that there are vulnerabilities in the Tailscale product awaiting discovery. Especially as, AFAIK, Tailscale have never had a formal security audit on their software.<p>So we install it on hardened bastion hosts in an old-school &quot;jump host&quot; model. So people can still get access to where they need to be, but we don&#x27;t need to install Tailscale&#x27;s unaudited shit on every single server &#x2F; vm &#x2F; etc.<p>And we only use Tailscale as a glorified VPN, we don&#x27;t use their hundreds of extra random features like this SSH one.<p>In terms of SSH, we use old-school OpenSSH and SSH certificates. Its really not that difficult and its really not expensive, you can do offline signing with Yubikeys, no need for expensive HSMs.
    • evan_a_a2 hours ago
      &gt;We very much fear at $work that there are vulnerabilities in the Tailscale product awaiting discovery<p>Spoiler alert: This applies to all software. This is why security preaches defense in depth.
      • traceroute662 hours ago
        &gt; Spoiler alert: This applies to all software. This is why security preaches defense in depth.<p>Thank you Mr&#x2F;Mrs Pedant.<p>However this is a VPN product I am talking about which has an integral part in the defence in depth of which you speak.<p>Therefore it is only right and proper that I, and others, should be able to trust them to a greater degree. Never 100% of course, as you say. But if you are selling me a security product then you should be able to demonstrate you have put some damn effort into securing it.<p>&quot;insecure argument handling&quot; in a security product is not a good look. It stinks of sloppy coding practices followed up by a lack of security auditing.
    • Bnjoroge26 minutes ago
      Did you try Headscale? <a href="https:&#x2F;&#x2F;github.com&#x2F;juanfont&#x2F;headscale" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;juanfont&#x2F;headscale</a> or netbird? The latter has been great for me.
      • traceroute660 minutes ago
        &gt; Did you try Headscale? <a href="https:&#x2F;&#x2F;github.com&#x2F;juanfont&#x2F;headscale" rel="nofollow">https:&#x2F;&#x2F;github.com&#x2F;juanfont&#x2F;headscale</a> or netbird?<p>Am aware of them but IIRC they are both unaudited which kind of brings us back to square one ? We would still end up running them at arms-length as we do with Tailscale at the moment.<p>Also isn&#x27;t Headscale server-side only ?
    • Retr0id1 hour ago
      I&#x27;ve been planning a similarly &quot;paranoid&quot; (but apparently not that paranoid) Tailscale setup, for the same reasons.<p>Another concern I have is whether a compromise of Tailscale&#x27;s own infra could let an attacker just add itself to my network. Apparently the &quot;Tailnet Lock&quot; feature mitigates this, but it is <i>off by default</i>. If I was an APT, compromising Tailscale would be priority number 1!
      • traceroute661 hour ago
        &gt; Another concern I have is whether a compromise of Tailscale&#x27;s own infra could let an attacker just add itself to my network. Apparently the &quot;Tailnet Lock&quot; feature mitigates this, but it is off by default.<p>Yeah, we use &quot;tailnet lock&quot; to sort of cover that. AFAIK its the only option available.<p>I say &quot;sort of&quot; because &quot;tailnet lock&quot; is a bit half-assed in its design and implementation.<p>For example, you cannot sign new nodes from mobile devices (e.g. iOS). And as we know, locking down iOS is easier than a full desktop machine. So that&#x27;s a bit of a missed opportunity. And as usual, there&#x27;s a Tailscale Github issue open for it for years ...<p>And in practice, the &quot;tailnet lock&quot; addition is done through the `tailscale` software on the desktop&#x2F;laptop. Its click a button or run a CLI without further authentication&#x2F;authorisation required. So basically anyone could do it. And the keys are, of course, open to exfiltration, you can&#x27;t use a Yubikey or anything like that. And you can&#x27;t require multi-signer. Complete joke really.<p>So, yeah, &quot;better than nothing&quot; is the way I would summarise &quot;tailscale lock&quot;.
    • ivlad2 hours ago
      Genuine question, if you use bastion hosts, why do you need Tailscale? Why not to expose tcp&#x2F;22 to the internet and allow public key authentication only (or, certificate based one, if you prefer fancy)? OpenSSH security track record seems to be better than that of Tailscale.
      • traceroute661 hour ago
        &gt; Genuine question, if you use bastion hosts, why do you need Tailscale? Why not to expose tcp&#x2F;22<p>Fair question. The short answer is my wording was a little off.<p>We do have pure SSH bastion hosts. Those are OpenBSD-based with a few tweaks, but basically they are locked-down and heavily monitored to within an inch of their life.<p>The reason Tailscale is there is mostly so the non-techies can access intranet portals and such-like.<p>But Tailscale does have a useful party-trick for the techies too, in that you can do DNS-suffix based routing (without needing to use Tailscale&#x27;s DNS).<p>So they can automagically hop via a Tailscale bastion host to &quot;*.$region.rds.amazonaws.com&quot; or whatever. You just specify the DNS suffix and anything on that wildcard will work. It therefore enables us to further harden access to that stuff to a source IP of the Tailscale bastion hosts (in addition to the usual security stuff, of course).<p>Tailscale takes care of the automagic load-balancing&#x2F;re-routing to the Tailscale bastion hosts, so we just have a bunch installed in random geographically-dispersed places and as long as &gt;0 are up and running the Techies will always have a route to where they need to be.<p>Obviously the above is over-simplified summary before the pedants start picking it apart. ;)
    • fragmede2 hours ago
      Tailscale contracts with cybersecurity firm Latacora to conduct traditional assessments, advisory services, design reviews, auditing and testing.<p><a href="https:&#x2F;&#x2F;tailscale.com&#x2F;security" rel="nofollow">https:&#x2F;&#x2F;tailscale.com&#x2F;security</a>
      • traceroute662 hours ago
        &gt; Tailscale contracts with cybersecurity firm Latacora to conduct<p>And these published audits of the `tailscale` software are where ?<p>Even half-serious VPN providers like Mullvad publish in public their regular security audits of their app and infrastructure.<p>There is zero reason Tailscale cannot do the same.<p>And frankly, given the nature of this vulnerability, &quot;insecure argument handling&quot; I&#x27;m not entirely sure it has been audited ? Or if it has, they should be looking for a new auditor ASAP !
        • _joel1 hour ago
          Agree, but I&#x27;d class Mullvad as <i>the</i> most serious VPN provider, personally.
          • traceroute661 hour ago
            &gt; I&#x27;d class Mullvad as the most serious VPN provider<p>I agree. Its annoying that lots of places have recently been blanket-banning Mullvad IP ranges.<p>Their sister-company Tilitis[1] is also doing interesting things with the Tkey product.<p>The present version has limitations due to the original security model but the up-and-coming version has a revised security model to make things a bit more &quot;real-world&quot; useful whilst not making any security trade-offs.<p>[1] <a href="https:&#x2F;&#x2F;www.tillitis.se&#x2F;" rel="nofollow">https:&#x2F;&#x2F;www.tillitis.se&#x2F;</a>
  • tptacek12 hours ago
    This is such a venerable and ancient class of bugs, going at least as far back as AIX 3. Glad to see they&#x27;re still makin&#x27; &#x27;em like they used to.<p>(If you had SSH access to a host in your Tailscale ACL, you could log in as `-i` and get a root login.)
    • unprovable3 hours ago
      It&#x27;s so old skool, it&#x27;s almost new again... almost... Still waiting for that third (or fourth?!) wave of XXE (or similar) bugs.
    • RossBencina10 hours ago
      I&#x27;m somewhat alarmed that the context that this bug was running in was capable of root login. Is there a reason that an SSH login process would, by default, have enough capabilities to facilitate direct root login?
      • yjftsjthsd-h9 hours ago
        If it runs as your user and can only log in as you, then I wouldn&#x27;t expect it to be able to become root. But if it can log you in as different users, I would expect that 1. it needs to run from root, and 2. it can log in as root.
      • anilakar6 hours ago
        We did Tailscale-like SSH reverse tunnels at scale first in 2013 and the main issue has always been that there are no good libraries. Bash scripting around the OpenSSH binaries is pretty much the only way to go.<p>There&#x27;s Paramiko, but Python is still a huge liability in memory-constrained systems.
        • formerly_proven5 hours ago
          libssh, libssh2. These are totally independent and unrelated code bases, libssh is maintained by Red Hat mainly for ansible and some other tools, libssh2 was created for curl. libssh2 is client-only, libssh can also be used to implement servers.
      • amluto2 hours ago
        Making a useful multi-uid-capable daemon that <i>can’t</i> become root but is not so nerfed that no one uses it is nontrivial. If nothing else, what policy would you use? Why do you think that no other uid is equivalent to root?
    • iririririr10 hours ago
      you can also add parameters to env vars in some popular cloud providers for the same effect.
  • doublepg2311 hours ago
    I’m a heavy Tailscale user, so I do trust them quite a bit, but I never used the Tailscale SSH feature. I feel like OpenSSH’s security record is pretty unbeatable, not sure why I’d swap over for such a security-sensitive tool.
    • OJFord6 hours ago
      The SSH vulnerability here only applies if the attacker is already on the network. It violates your Tailscale ACLs, but it&#x27;s not arbitrary external root ssh access. Arguably that&#x27;s a more secure starting point than vanilla ssh to publicly accessible machine.
      • semi-extrinsic5 hours ago
        OTOH, if you run vanilla ssh on a publicly accessible machine where only port 22 is open, sshd only allows publickey-based authentication and the only accepted key types are FIDO2&#x2F;U2F hardware-backed keys, it&#x27;s probably more secure again (less attack surface).
        • angry_octet33 minutes ago
          Unless you&#x27;re using short lived SSH CA certificates, SSH key access has only modest security. You would need to buttress it with TOTP 2FA or enforce Yubikey generation&#x2F;storage of keys, neither of which are at all default.<p>Even then, it&#x27;s obvious you are running SSH, and they can fingerprint the OS, and external logging shows which machines are connecting, and hence have said SSH keys. If they have SSH open they become targets; if they come from CGNAT, carriers can leak location via CGNAT behaviour.<p>In contrast tailscale makes this much harder.
      • fodkodrasz5 hours ago
        With a plain VPN like WireGuard when they get access to your network, they don&#x27;t have plain ssh, not to mention root ssh access to hosts. This is a serious issue.
    • bakies11 hours ago
      Yeah pretty much just use tailscale as a vpn.. do one thing as they say.
    • jdiff11 hours ago
      I&#x27;ve used it before to access my tailnet machines through a browser on a machine I can&#x27;t download software on.
      • Shorel7 hours ago
        I just don&#x27;t use stranger&#x27;s machines to access my personal stuff. Possibly compromised stranger&#x27;s machines. I don&#x27;t see the benefit about that, as I have more laptops than I need.
        • jdiff2 hours ago
          That&#x27;s cool. Others are not like you and may have use&#x2F;need of things that you have no use&#x2F;need for is what I&#x27;m trying to communicate here.
    • dgacmu10 hours ago
      I used it for a bunch of remote monitor boxes to have a way of centrally managing ssh access to things that were often on- and off-line. It was simple and convenient and access was easily revocable.
    • isatty11 hours ago
      Convenience for the most part but in general, I agree. I like having it as an option.
  • jcarrano5 hours ago
    &gt; usernames were passed as arguments to getent(1) to retrieve the corresponding passwd entry<p>Always try to use actual API&#x2F;system calls (in this case getpwnam) instead of calling sub-processes.
  • eviks6 hours ago
    &gt; Tailscale SSH now rejects usernames with leading dashes.<p>Is the proper fix not restricting users not possible in these poorly designed ancient systems?<p>Similarly re another issue: why not just fix the permission issues instead of restricting users?<p>&gt; Tailscale now disallows the use of UIDs or numeric-only usernames via SSH to avoid this ambiguity
    • pferde4 hours ago
      The proper fix would be to not use getent CLI tool in their logic, but instead use proper system APIs for looking up user account entries, like one of earlier comments here already mentions. This is shocking amateur hour!<p>My guess is they hastily threw together something hacky in early development, and forgot to replace it with a real, safe solution later.
      • rfoo3 hours ago
        The issue here is there is NO single system API for looking up user account entries on Linux.<p>It&#x27;s implemented in libc. So you need to link to libc. Tailscale is a Go binary, and they probably prefer it to be statically-linked. glibc NSS implementation also REQUIRES you to load `.so` so you just can&#x27;t emulate it in Go.<p>Then, &quot;link to libc&quot;. Which libc? glibc? musl?
        • pferde3 hours ago
          But of course there is, it&#x27;s part of POSIX, implemented in libc. And if you&#x27;re using a higher level language, they all have their own wrappers around libc&#x2F;POSIX APIs. Here is golang&#x27;s: <a href="https:&#x2F;&#x2F;pkg.go.dev&#x2F;os&#x2F;user" rel="nofollow">https:&#x2F;&#x2F;pkg.go.dev&#x2F;os&#x2F;user</a>
        • Chu4eeno3 hours ago
          &gt; The issue here is there is NO single system API for looking up user account entries on Linux.<p>Yes there is, and you answered in the next line, it is implemented in libc.<p>If you want to check authentication use libc don&#x27;t try to implement crypto and authentication yourself.
    • sam_lowry_4 hours ago
      There is a whole class of security issues where <i>fixes are worse that the issues themselves</i>. Case in point, the OpenSSH itself that sends 100 packets on each keystroke to avoid timing attacks.
      • fragmede4 hours ago
        Why is that worse than the issue itself? If someone could figure out, say, my root password via an ssh timing attack, that seems bad. Sending 100 packets for each keystroke to protect against this seems cheap in the face of that.
        • sam_lowry_1 hour ago
          Because it breaks our mental model of how things work.
  • s_ting7655 hours ago
    I don&#x27;t see the point of publishing a security bulletin if you are not going to timely push the fix to artifacts on all affected platforms. Tailscale needs to do better on their release process, docker hub shows last update was 8 days ago.
    • dust-jacket3 hours ago
      I don&#x27;t mind having a bulletin so much as the claim that it&#x27;s fixed in 1.98.9 or newer, when that release doesn&#x27;t appear to <i>exist</i> yet. Feels pretty weird practice to advise upgrading to a non-existent version.
      • s_ting7652 hours ago
        1.98.9 has already been tagged since bulletin was published (don&#x27;t know why they chose on github to tag but not release).<p>1.98.9 version exists! That&#x27;s not the question. It should already have been made available for Linux distros assuming this resource from Tailscale is accurate <a href="https:&#x2F;&#x2F;pkgs.tailscale.com&#x2F;stable&#x2F;?v=1.98.9" rel="nofollow">https:&#x2F;&#x2F;pkgs.tailscale.com&#x2F;stable&#x2F;?v=1.98.9</a><p>Edit: Their changelog also mentions the version: <a href="https:&#x2F;&#x2F;tailscale.com&#x2F;changelog#all" rel="nofollow">https:&#x2F;&#x2F;tailscale.com&#x2F;changelog#all</a>
        • dust-jacket1 hour ago
          Ah, OK, its the weird GitHub non-release that threw me. Thank you!
    • dijit5 hours ago
      so you can disable or mitigate it…
  • drnick110 hours ago
    I&#x27;ll stick to my 100% self-hosted Wireguard setup, thank you very much.
    • m_mueller9 hours ago
      Why not tailscale plus head scale for self hosting?
      • diarrhea7 hours ago
        I do not understand this rebuttal.<p>I also run self-hosted Wireguard. Initially on a Debian box, nowadays it is integrated into my router (admittedly, this is closed source). For around 6 years at this point.<p>The whole thing could not be easier and simpler. It has never randomly broken on me. It is fast. It is free. There is no middle man, no vendor.<p>I never understood the popularity of Tailscale, though that is on me. I&#x27;m sure it is a great product, I just never tried it, do not seem the target audience.<p>What confuses me is the often accompanying, sometimes aggressive anti-selfhosting stance in these sorts of threads. I do not see this in other topics, e.g. someone mentioning they run Jellyfin isn&#x27;t met with &quot;why not Plex?&quot;. Where does that come from? We are on <i>Hacker</i>News, not ProductShillNews, aren&#x27;t we? I guess self hosting Wireguard is too boring to warrant any further discussion? The VPN equivalent of a Toyota Corolla.
        • hdgvhicv4 hours ago
          My WireGuard uses (either at home or at work) are very much mobile client to single network<p>Where Tailscale comes into its own is automatic managing of mesh networking (like an “sdwan” solution). The other thing it excels at is firewall busting - if you have a firewall (with or without address translation) which only allows outgoing traffic to be established (with UDP timeouts for session) then Tailscale also works in a similar way to turn&#x2F;stun.<p>If I needed that capability then I’d be looking at Headscale. I don’t need it though.<p>Remember that this is hackernews, not slashdot. Where the community used to be far smaller and the technology far smaller it was quite normal for everyone to understand basic building blocks of ip addresses, use open source software, wear t-shirts threatening to replace people with a small shell script etc.<p>It’s not the same community, many people here have no real understanding of computer fundamentals, but instead have expertise in specific narrow areas. They also have little interest in things like free software, but do have an interest in building a new billion dollar company to sell to a behemoth.
          • sam_lowry_2 hours ago
            Thanks for the first 3 paragraphs, but big no to the last two. <i>The vocal minority</i> shapes communities.
          • xorcist3 hours ago
            &gt; it excels at is firewall busting<p>Some would consider that an anti-feature. Firewalls are not to be busted. Nothing good lies at the extreme end of working around overly strict policies. Change the policy instead.
        • MobiusHorizons7 hours ago
          I think Tailscale is popular because of how plug and play it is for most people. Although the main reason I use it over self hosting wireguard is the NAT busting it does, which has so far worked flawlessly for me with no setup aside from installing on both devices. There is nothing wrong with self hosting wireguard, but it doesn&#x27;t actually do the same job as tailscale.
          • mr_mitm6 hours ago
            Wireguard by itself also doesn&#x27;t allow for 2FA or expiring keys. Not as relevant for private use, but some orgs need it for compliance. The idea was always that things like that need to be implemented by an application on top of it, so you end up with something like tailscale eventually.
          • mfru6 hours ago
            as someone who uses tailscale: exactly this.<p>i have my homelab only reachable via tailscale and can access everything i would ever want on the go that way. it was a matter of 15 min to get it all working.
          • diarrhea7 hours ago
            NAT busting is a great point.
        • maxgashkov2 hours ago
          &gt; I never understood the popularity of Tailscale, though that is on me.<p>&gt; I guess self hosting Wireguard is too boring to warrant any further discussion?<p>It&#x27;s popular because you don&#x27;t have to deal with NAT punching. It &quot;just works&quot;, all the time. And Wireguard is not too boring, it&#x27;s just not enough on its own.<p>I&#x27;m all for self-hosting and this is exactly why I prefer to use Tailscale and not have to manage jump-hosts and STUN points on some cloud, given that I won&#x27;t be able to make it as reliable as Tailscale and as cheap as Tailscale (effectively $0). So this is literally the only tradeoff I made while self-hosting everything else.
        • m_mueller5 hours ago
          it wasn&#x27;t meant as a rebuttal, I&#x27;m genuinely asking. tailscale + headscale was just recommended to me, hence that&#x27;s what I&#x27;m using for self hosting. is wireguard&#x27;s client roughly equivalent to tailscale&#x27;s? especially tailscale&#x27;s always-on nature is very appealing.
        • fragmede7 hours ago
          How do I install wire guard on my mom&#x27;s Apple TV?
      • apexalpha6 hours ago
        I also tested tailscale, headscale and netbird and found all these drain your battery on mobile.<p>Others report no issues but I had massive drain on iOS even with only 4 connections open.<p>Native wireguard is unnoticeable.
    • nicman237 hours ago
      i really dislike that there is no way to do dhcp for new clients and that i have to manually define peers in each &quot;exit node&quot;
      • gear54rus4 hours ago
        Because wireguard to tailscale is like git to git GUIs. It&#x27;s solid base but never should be used separately without a proper wrapper if one wants to keep one&#x27;s sanity.
        • dust-jacket3 hours ago
          But are there any good self-hosted wrappers?<p>I ditched wireguard for tailscale for the ease of managing it. I&#x27;d much rather run my own independently but CBA with the config editing hassle.
          • nicman2322 minutes ago
            tailscale is self-hostedable
    • doctorpangloss8 hours ago
      haha self hosted wireguard, an opportunity to find out AllowedIPs: 0.0.0.0&#x2F;0 does the opposite of what you think it will do
      • sva_4 hours ago
        If you don&#x27;t care to invest half an hour into learning some basics of how computer networking and in particular CIDR notation and subnet masks work, maybe it is not for you.
        • doctorpangloss27 minutes ago
          I see that you don&#x27;t know what AllowedIPs does :)
          • sva_12 minutes ago
            Yeah right, I manually set up 4 servers, 2 pcs and 2 phones in a wireguard mesh network and I don&#x27;t understand what it does.
      • hdgvhicv4 hours ago
        Allow any (ip4) traffic to enter the tunnel, install a route in the default routing table to make that happen (well the second depends on the client)<p>Does it do the opposite of that?
      • cromka8 hours ago
        [dead]
  • e4011 hours ago
    So, giving access via tailscale but using OpenSSH is safe, right?
    • lugoues11 hours ago
      Yes, this only involves their wrapper that is managed by ACL rules.
    • iririririr10 hours ago
      as much as handing control to a remote third part is, yes.
      • cevn9 hours ago
        Good point. I self host headscale but it also has the ssh feature, probably also insecure.
        • OJFord6 hours ago
          Not necessarily, it&#x27;s a clean room implementation. Even if leading dashes was known&#x2F;documented&#x2F;tested to implement they might have done it differently. And maybe it was an implementation detail that it was ever allowed, but that&#x27;s a weird username, headscale implementation happened not to allow it, and nobody ever noticed the discrepancy.
  • luciana1u10 hours ago
    tailscale ssh: replacing a 25-year-old battle-tested codebase with a startup&#x27;s Go rewrite and then acting surprised when it has bugs
  • mintflow9 hours ago
    &gt;&gt;&gt; We would like to thank Anthropic and Ada Logics for reporting this issue.<p>it seems anthropic also use tailscale or it&#x27;s just being discovered by the mythos model?
    • tristanj8 hours ago
      I presume Ada Logics has access to Anthropic&#x27;s Mythos model via Project Glasswing, and Ada Logics discovered this exploit during their vulnerability research.
  • modeless11 hours ago
    Tailscale SSH has caused me other problems in the past because it takes over port 22. I&#x27;m not a fan.
    • newdee6 hours ago
      It takes over port 22 on the Tailscale interface only. Only had problems with this when I’ve wanted to hit a host’s non-Tailscale ssh service via Tailscale. Otherwise it’s been great for me
    • LeoPanthera10 hours ago
      That is what it&#x27;s supposed to do, though. It&#x27;s not a secret.
    • huflungdung10 hours ago
      [dead]
  • mintflow9 hours ago
    pure logic error, the undergoing tailscale rust rewrite can&#x27;t help this too:)
    • bestouff7 hours ago
      If it used one of the standard arguments-handling crates (e.g. &quot;clap&quot;) there&#x27;s no way it can happen.
      • pferde4 hours ago
        If it used one of the standard system APIs for looking up user accounts (e.g. getpwnam(3)), there&#x27;s no way it can happen.<p>This is incredibly bad engineering, on level of a SQL injection, in 21st century. Something a highschool student experimenting with scripting could come up with, but not a supposedly professional software company.
    • mintflow9 hours ago
      that said, the limit impact perhaps is only affected multiple users in tailnet if the ACL is not configure correctly<p>As single tailnet+single user, perhaps it&#x27;s just okay
  • kbumsik11 hours ago
    Why own numbering instead of CVE?
    • vngzs11 hours ago
      It lets organizations (Tailscale) control the timing and narrative around the disclosure more directly. Organizations sometimes avoid the bureaucracy of going through CVE Numbering Authorities by self-publishing. Often a CVE assignment follows self-disclosure, especially when there&#x27;s pressure to interoperate with vuln-scanning&#x2F;compliance tooling
      • bigfatkitten10 hours ago
        And sometimes it’s just impossible to get a CVE number in a reasonable amount of time, or indeed at all.
    • wereHamster8 hours ago
      Some reasons why an org might want to become their own CNA: <a href="https:&#x2F;&#x2F;daniel.haxx.se&#x2F;blog&#x2F;2024&#x2F;01&#x2F;16&#x2F;curl-is-a-cna&#x2F;" rel="nofollow">https:&#x2F;&#x2F;daniel.haxx.se&#x2F;blog&#x2F;2024&#x2F;01&#x2F;16&#x2F;curl-is-a-cna&#x2F;</a>
      • Retr0id1 hour ago
        To be clear creating your own custom IDs isn&#x27;t the same thing as being a CNA, but some of the motivations are the same.
  • TacticalCoder36 minutes ago
    I&#x27;ll fix this entire HN thread for you all and you&#x27;ll thank me later:<p><pre><code> s&#x2F;bug&#x2F;backdoor&#x2F;g</code></pre>
  • cyberax11 hours ago
    &gt; &quot;Tailscale SSH now rejects usernames with leading dashes.&quot;<p>Really? That&#x27;s the fix?<p>A proper fix is to use &quot;--&quot; to separate arguments.
    • valleyer11 hours ago
      A proper fix is not to shell out to a command at all; use getpwnam(3) or similar.
    • catlifeonmars8 hours ago
      “--“ doesn’t work on all versions of getent.<p>A better fix is to call “getent passwd” with no user controlled arguments and then parse the resulting list. This gets rid of the input sanitization problem entirely.
      • tryauuum2 hours ago
        that&#x27;s stupid. getent passwd will fetch the user list from the network depending on setup. Have fun fetching 40000 records from the network every call
      • cyberax7 hours ago
        Are there any actual systems that can run Tailscale and that have faulty getent?
    • sedatk11 hours ago
      Their fix just future-proofs it in case the same bug gets reintroduced.
      • turbert10 hours ago
        A correct implementation would be to just call glibc directly, this seems like a hasty fix to get the patch out the door. The history of vulns from bad shell escaping is as old as bash, whenever possible you probably shouldn&#x27;t be mixing code and data, especially in a security critical application like this.
        • raggi9 hours ago
          The fact that there is no portable way to link the relevant functions that works reliably across all distributions of Linux is a failure of POSIX and GNU, and unfortunately is largely the Linux distribution story in a nutshell.<p>Your answer is mostly correct, except that when you tug on that thread the shelf comes off the wall, the plaster comes with it, and then it cracks the water pipes on the way to the floor.
      • cyberax11 hours ago
        This is just a dirty fix. It adds weird restrictions and masks issues.<p>Refactoring external invocations to use safe argument handling is a better way to fix it. Along with tests that exercise weird names.
        • raggi9 hours ago
          <a href="http:&#x2F;&#x2F;github.com&#x2F;tailscale&#x2F;tailscale&#x2F;commit&#x2F;e4144230f410204aa2f43a07a57182c751239597" rel="nofollow">http:&#x2F;&#x2F;github.com&#x2F;tailscale&#x2F;tailscale&#x2F;commit&#x2F;e4144230f410204...</a>
          • cyberax4 hours ago
            All the hallmarks of an LLM fix right there...
        • sedatk10 hours ago
          I argue the opposite: there’s no better fix for this. You can write the most elegant fix, whatever it is, and prevent that from happening only on the codebase that’s fixed. That doesn’t mean that the codebase will always be the only authority on authentication.<p>The username policy fixes this issue for good, regardless of whatever you write in the future, or whatever new mechanism is introduced.<p>It’s a restriction for sure, but it’s not a nonsense restriction? Who would have a username starting with a hyphen? I didn’t even know it was possible until today.
          • turbert10 hours ago
            &gt; I argue the opposite: there’s no better fix for this<p>The better fix would be to not have the username pass through a parser looking for cli flags in the first place.
            • OJFord6 hours ago
              How do you propose to do that when username is a possible argument?
  • farfatched8 hours ago
    Sadly, yet another path to root via Tailscale.<p>If their scope grows, and they run so much as root, it won&#x27;t be their last.
  • ishweta7 hours ago
    [dead]