Flirt: The Native Backend

(blog.buenzli.dev)

20 points by senekor3 days ago

4 comments

exceptione40 minutes ago
<pre><code> > Imagine a commit in a patch series changes 100 lines. 99 of the lines are good, but the first round of review suggests to add a missing semicolon on one of the lines. The author does that by amending the existing commit, to avoid an unseemly "add missing semicolon" commit ending up in the project history. After a force-push (or new patch series submission), reviewers are generally presented with the full 100-line diff to review, because the tools don't understand that only one line changed since the last review. </code></pre> In the PR-workflow, why not add fixup! commits? I think that when the PR is approved, the PR owner should be free to rewrite the history in their PR.Flirt looks interesting, but I am not sure if it would solve a real problem for me.
CurleighBraces1 hour ago
If you haven't read the first blog post it's pretty good at explaining the concepts.<a href="https://blog.buenzli.dev/announcing-development-on-flirt/" rel="nofollow">https://blog.buenzli.dev/announcing-development-on-flirt/</a>The demo is particularly good if you can get past ( by the authors own admission ) slow typing speed.As with everything these days I can see this being even more useful in reviewing agent code.For example if an agent has spat out a bunch of code that I've reviewed and then I've asked it to make changes, I definitely do not want to review all that code again in the same diff later.
- OJFord1 hour ago
 That's a really good point, at the moment I struggle to get past wanting it to create small logical changes that I can commit individually. If I could review them better such as Flirt describes, then maybe I don't care so much, and a big 'create initial implementation' commit becomes more acceptable, for example.
N_Lens1 hour ago
For those curious - Flirt is an incremental code review tool.
seism3 hours ago
Excellent. Starting with the domain name :)